Fix an unnecessary cancel/re-request with GitHub Copilot requests. #12988
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmcmorran
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
These changes are safe, although the semantics are a bit confusing.
If cancellation is requested, that's typically an indication that the caller no longer cares about the result, so the old code was making that pattern explicit. However, it's possible that Copilot is behaving in an unexpected way here by requesting cancellation but still populating an internal cache with results that come later.
|
I was going to look at additional changes on Monday to remove some of the additional unnecessary cancelling -- and I think I'm going to create a separate function specifically for the register callback, since that appears to be a special case in regards to cancelling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #12773 .
The
withLspCancellationHandlingis only called for the registerRelatedFilesProvider requests in which the cancel isn't needed, but I'm not sure what the best way to handle it if we wanted to use that in other places where maybe the cancel after getting the results is desirable. I could pass a bool to the method or rename it or create a 2nd function, etc., but I figured we could just deal with that refactoring when we have a caller that needs that difference in behavior?